-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move rhel9.4 test to testing-farm #7545
Conversation
@yih-redhat could you please fix commit line error? Thanks. |
fixed. |
.github/workflows/rhel-9-4.yml
Outdated
update_pull_request_status: true | ||
pull_request_status_name: "edge-commit-9.4" | ||
tf_scope: private | ||
tmt_plan_regex: edge-commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tmt plan regex should be edge-test
and use only one to run all palns in edge-test.fmf. We can't split the tests because each separated test will consume one github runner. The whole org only has 20 concurrent runner limitation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
test: edge-test | ||
execute: | ||
how: tmt | ||
provision: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add required cpu and memory here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
.github/workflows/rhel-9-4.yml
Outdated
endsWith(github.event.comment.body, '/test-rhel-9-4-minimal') || | ||
endsWith(github.event.comment.body, '/test-rhel-9-4-arm-minimal') || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove all of them and just keep /test-rhel-9-4
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
.github/workflows/rhel-9-4.yml
Outdated
git_url: ${{ needs.pr-info.outputs.repo_url }} | ||
git_ref: ${{ needs.pr-info.outputs.ref }} | ||
update_pull_request_status: true | ||
pull_request_status_name: "edge-commit-9.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status name should be like edge-rhel-9.4
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
.github/workflows/rhel-9-4.yml
Outdated
git_url: ${{ needs.pr-info.outputs.repo_url }} | ||
git_ref: ${{ needs.pr-info.outputs.ref }} | ||
update_pull_request_status: true | ||
pull_request_status_name: "edge-vmdk-x86-rhel-94" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not need additional jobs for vmdk, arm. Only use one workflow job and filter x86_64 or aarch64 with tmt plan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Use one runner and use matrix of arch sometimes will cause timeout issue and cannot see the sub-job status. So I changed it back to use two runners, one is for x86 and one is for aarch64. |
@henrywang Could you please review this pr? |
Currently there are still two bugs in testing-farm that block some case from success, but we can enable rhel9.4 test first.